Parse version -json output and fall back to plaintext #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13
I didn't add more tests because it seemed like we'd be just testing mostly stdlib internals - either os.Exec or encoding/json. I'm open to ideas on what else to test though.
Also I think that exposing
VersionOutput
from theVersion()
method would be a good idea, but I avoided that just to retain compatibility, for now. Also it might be helpful to leverage (not yet published) library for parsing the provider addresses too. Either way I can open a separate issue for this.