-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lib): Fixing path for terraformhclmodule asset approach #961
fix(lib): Fixing path for terraformhclmodule asset approach #961
Conversation
@javier-caylent Thank you for taking the time to really dig into the issue and come up with a fix. I think it makes sense to hold off on merging this until either #947 or #948 is merged as they would result in some updates being needed. For additional context, conceptually it shouldn't matter whether a local module is referenced absolutely or relatively; however, Terraform internally parses them differently. See https://github.com/hashicorp/terraform/blob/e09b831f6ee35d37b11b8dcccd3a6d6f6db5e5ff/internal/addrs/module_source.go#L51 |
@jsteinich do you know what we need to do to get this merged? |
@ansgarm at a minimum this needs to be rebased on the latest main as there are conflicting files. @DanielMSchmidt had been working on a preferable long term solution with #948. I could pick that back up before 0.7; else we could take this approach for the time being (maybe add a comment about the workaround being done). |
Seems like this was addressed in #1476 - can you confirm @jsteinich ? Close? |
Yep. |
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
No description provided.