Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Add pr lint for semantic releases #721

Merged
merged 6 commits into from
May 26, 2021

Conversation

skorfmann
Copy link
Contributor

@skorfmann skorfmann commented May 25, 2021

This is part of #656 and validates PR titles and the commit message of single commit PRs to follow semantic messages.

It's using this Github Action: https://github.com/marketplace/actions/semantic-pull-request

From their readme:

Examples for valid PR titles:

fix: Correct typo.
feat: Add support for Node 12.
refactor!: Drop support for Node 6.
feat(ui): Add Button component.
Note that since PR titles only have a single line, you have to use the ! syntax for breaking changes.

@skorfmann skorfmann changed the title Add pr lint for semantic releases chore(tests): Add pr lint for semantic releases May 25, 2021
@skorfmann skorfmann force-pushed the feat-automate-release-process branch from 2b74a74 to 84dbdcf Compare May 25, 2021 13:06
skorfmann added 4 commits May 26, 2021 13:37
Triggered by a discussion with @ansgarm how the Go feature would have
been scoped. We considered adding an explicit `global` scope, as well as
introducing a `jsii` or `languages` scope. However, we came to the
conclusion that this will become bloated very quickly. Hence, for
things which are touching essentially everything, we thought it's better
to just go without an explicit scope.
@skorfmann skorfmann merged commit ca21ff9 into main May 26, 2021
@skorfmann skorfmann deleted the feat-automate-release-process branch May 26, 2021 12:11
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants