fix(lib): escape newlines in terraform functions #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
force-pushed
the
terraform-functions-should-escape-inputs
branch
7 times, most recently
from
06e5e7f
to
2d82cd6
Compare
Previously newlines were added to the synthesised JSON, which JSON only accepts if escaped Closes #1165
This might feel counter-intuitive but quotes are not required for an 'outer' expression as the string will get quoted somewhere else already. Only inner expressions need those extra quotes as they would else be treated as raw expressions like e.g. `var.something`.
…l objects as inputs to functions) This has previously only been done for objects but not for arrays.
ansgarm
force-pushed
the
terraform-functions-should-escape-inputs
branch
from
5a48e5a
to
99a2a32
Compare
ansgarm
approved these changes
Nov 10, 2021
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously newlines were added to the synthesised JSON, which JSON only accepts if escaped${} into $ ${}
This PR also escapes
Closes #1165