Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add example azure service bus #1063

Merged

Conversation

speedfl
Copy link
Contributor

@speedfl speedfl commented Sep 22, 2021

Hello Hashicorp team

I would like to propose this example for azure service bus with queue trigger

Best regards

Geoffrey

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 22, 2021

CLA assistant check
All committers have signed the CLA.

@speedfl speedfl force-pushed the feature/add-example-service-bus-queue-trigger branch from 8865a65 to 3093f9b Compare September 22, 2021 14:05
@speedfl speedfl changed the title feat(example): add example azure service bus feat(examples): add example azure service bus Sep 23, 2021
@speedfl speedfl force-pushed the feature/add-example-service-bus-queue-trigger branch from 3093f9b to d117a91 Compare September 23, 2021 06:55
Copy link
Contributor

@skorfmann skorfmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the example 👍 Left a suggestion and a question

@speedfl
Copy link
Contributor Author

speedfl commented Sep 24, 2021

@skorfmann it seems that I cannot sign again the CLA.
I already signed it for previous PR and now it is not taken into account for this one
unabletosign

@speedfl speedfl force-pushed the feature/add-example-service-bus-queue-trigger branch from ffcd95f to 4841479 Compare September 24, 2021 07:30
@ansgarm
Copy link
Member

ansgarm commented Oct 12, 2021

Hi @speedfl!
I just had a look at the commit, and it could be that the email on that commit is different from the one you normally use for Github (it ends with *.nce.amadeus.net). Maybe adding that email to your Github profile as an alternative email address could work (if you can receive emails on that address) – otherwise you could ammend the commit and change the author (e.g. git commit --amend --author="Author Name <[email protected]>").

@speedfl speedfl force-pushed the feature/add-example-service-bus-queue-trigger branch from 4841479 to 2cba286 Compare October 12, 2021 07:44
@skorfmann skorfmann merged commit 0028d63 into hashicorp:main Oct 12, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants