Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): link docs to Pocket codebase, YouTube #1062

Merged
merged 6 commits into from
Sep 23, 2021
Merged

chore(docs): link docs to Pocket codebase, YouTube #1062

merged 6 commits into from
Sep 23, 2021

Conversation

danieldreier
Copy link
Contributor

Am I missing any YouTube videos you all are aware of?

@danieldreier danieldreier added the documentation Improvements or additions to documentation label Sep 22, 2021
@danieldreier danieldreier self-assigned this Sep 22, 2021
skorfmann
skorfmann approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@skorfmann skorfmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are likely more, but I think it's sufficient 👍

laurapacilio
laurapacilio approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so I don't block, but suggesting some nits for you to change. Also - I think we had discussed adding a few sentences of description for each of the examples earlier up on this page so that users know what they are clicking on. I imagine we could pull some context out of the READMEs in those examples. After this PR is merged, would it be helpful for me to pull that context and draft the 1-2 sentence explanations?

website/docs/cdktf/examples.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/examples.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/examples.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/examples.html.md Outdated Show resolved Hide resolved
website/docs/cdktf/examples.html.md Outdated Show resolved Hide resolved
@laurapacilio laurapacilio mentioned this pull request Sep 22, 2021
Closed
@danieldreier danieldreier linked an issue Sep 23, 2021 that may be closed by this pull request
[Docs page] Examples #967
Closed
@danieldreier danieldreier merged commit 35df2f9 into terraform-io-docs Sep 23, 2021
@danieldreier danieldreier deleted the danieldreier-examples-docs branch September 23, 2021 14:04
@DanielMSchmidt DanielMSchmidt mentioned this pull request Oct 19, 2021
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laurapacilio laurapacilio laurapacilio approved these changes

@skorfmann skorfmann skorfmann approved these changes

Assignees

@danieldreier danieldreier

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.

[Docs page] Examples
3 participants
@danieldreier @skorfmann @laurapacilio