Module Generation Should Generate Output Getters #28
Milestone
Comments
Merged
skorfmann
added a commit
that referenced
this issue
Apr 30, 2020
This provides a fix for #12 and includes some refactoring around the resource parsing / emitting. The primary goal of the refactoring was, to split the parsing from the emitting to make it easier to understand. I'm still not quite happy with the result (in particular around the models, and that some logic is spread across multiple places). I think it needs another iteration, but for alpha it should do. Right now it's in the "it's working" state, and "jsii" will compile the "AWS" provider without an error. I haven't done a full sanity check of the generated resources, but for the most part it should be usable. In regards to the complex computed types, I'd see it as a first stab at the problem. It's not flexible and serves a very specific use case only. The goal: - Make complex computed types accessible - Provide type information for the computed properties of those types - Keep it within the constraints of jsii, namely no generics and no proxies (see #12) A few issues were created as a follow up - see #24 #25 #26 #27 #28 #29 #39
anubhavmishra
pushed a commit
that referenced
this issue
May 5, 2020
This provides a fix for #12 and includes some refactoring around the resource parsing / emitting. The primary goal of the refactoring was, to split the parsing from the emitting to make it easier to understand. I'm still not quite happy with the result (in particular around the models, and that some logic is spread across multiple places). I think it needs another iteration, but for alpha it should do. Right now it's in the "it's working" state, and "jsii" will compile the "AWS" provider without an error. I haven't done a full sanity check of the generated resources, but for the most part it should be usable. In regards to the complex computed types, I'd see it as a first stab at the problem. It's not flexible and serves a very specific use case only. The goal: - Make complex computed types accessible - Provide type information for the computed properties of those types - Keep it within the constraints of jsii, namely no generics and no proxies (see #12) A few issues were created as a follow up - see #24 #25 #26 #27 #28 #29 #39
|
I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
At the moment, the module generator generates accessors and interfaces for inputs. We should extend it to provide getters for outputs as well.
The text was updated successfully, but these errors were encountered: