fix(provider-generator): escape hyphens in provider names for Go pack…

…age identifiers resolves #1250
hashicorp · Nov 4, 2021 · 4b6c9bc · 4b6c9bc
1 parent 3058eb7
commit 4b6c9bc
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/packages/@cdktf/provider-generator/lib/get/__tests__/constructs-maker.test.ts b/packages/@cdktf/provider-generator/lib/get/__tests__/constructs-maker.test.ts
@@ -1,7 +1,11 @@
 import * as fs from "fs-extra";
 import * as os from "os";
 import * as path from "path";
-import { determineGoModuleName } from "../constructs-maker";
+import {
+  ConstructsMakerProviderTarget,
+  determineGoModuleName,
+  Language,
+} from "../constructs-maker";
 
 describe("constructsMaker", () => {
   describe("determineGoModuleName", () => {
@@ -79,4 +83,18 @@ describe("constructsMaker", () => {
       );
     });
   });
+  describe("ConstructsMakerProviderTarget", () => {
+    it("returns valid package name for Go", () => {
+      const target = new ConstructsMakerProviderTarget(
+        {
+          name: "google-beta",
+          fqn: "google-beta",
+          source: "google-beta",
+          version: "~> 4.0",
+        },
+        Language.GO
+      );
+      expect(target.srcMakName).toEqual("google_beta");
+    });
+  });
 });
diff --git a/packages/@cdktf/provider-generator/lib/get/constructs-maker.ts b/packages/@cdktf/provider-generator/lib/get/constructs-maker.ts
@@ -161,7 +161,7 @@ export class ConstructsMakerProviderTarget extends ConstructsMakerTarget {
       case Language.PYTHON:
         return this.simplifiedName;
       case Language.GO:
-        return this.name;
+        return this.name.replace(/-/gi, "_");
       default:
         return this.constraint.fqn;
     }