Skip to content

Commit

Permalink
Don't change visibility for "synthesizeAttributes" (#328)
Browse files Browse the repository at this point in the history
* Don't change visibility for "synthesizeAttributes"

In the recent Jsii release https://github.com/aws/jsii/releases/tag/v1.11.0 a detection for
changing visibility when overriding was added aws/jsii#1876 and prevents
it from building.

* Update snapshots to reflect the changed visibility
  • Loading branch information
skorfmann authored Aug 20, 2020
1 parent e4f6cb7 commit 08c474e
Show file tree
Hide file tree
Showing 11 changed files with 768 additions and 33 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export class ResourceEmitter {

private emitResourceSynthesis(resource: ResourceModel) {
this.code.line();
this.code.openBlock(`public synthesizeAttributes(): { [name: string]: any }`);
this.code.openBlock(`protected synthesizeAttributes(): { [name: string]: any }`);
this.code.open(`return {`);

for (const att of resource.synthesizableAttributes) {
Expand Down
Loading

0 comments on commit 08c474e

Please sign in to comment.