Add an optional ConfigurationStore interface #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briankassouf
commented
Jun 14, 2019
banks
reviewed
Jun 17, 2019
There was a problem hiding this comment.
Looks great @briankassouf!
A couple minor Qs/suggestions inline.
Co-Authored-By: Paul Banks <[email protected]>
mitchellh
reviewed
Jun 20, 2019
| // in memory and snapshotting periodically. By storing configuration changes, the | ||
| // persistent FSM state can behave as a complete snapshot, and be able to recover | ||
| // without an external snapshot just for persisting the raft configuration. | ||
| type ConfigurationStore interface { |
There was a problem hiding this comment.
Random drive-by comment: if this interface is only useful for FSMs, should you embed the FSM interface in here as well?
I tend to find that to be a fairly self-documenting behavior I appreciate.
There was a problem hiding this comment.
Good idea, i'll add that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FSMs that satisfy this interface will be sent configuration change updates after they are fully committed to the log