packer: error multiple paths in PACKER_PLUGIN_PATH #12967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nywilken
reviewed
May 10, 2024
packer/plugin_folders.go
Outdated
|
|
||
| "github.com/hashicorp/packer-plugin-sdk/pathing" | ||
| ) | ||
|
|
||
| // PluginFolder returns the known plugin folder based on system. | ||
| func PluginFolder() (string, error) { | ||
| if packerPluginPath := os.Getenv("PACKER_PLUGIN_PATH"); packerPluginPath != "" { | ||
| if strings.Contains(packerPluginPath, ":") { |
There was a problem hiding this comment.
The operator on windows is ";" you can use os.PathListSeparator here to determine if there are multiple paths defined.
When a user defines PACKER_PLUGIN_PATH in their environment, we need to error if their path defines multiple directories separated by `:`. This used to be supported, but this is removed with 1.11 as we're simplifying the loading process for plugins, so we opted to fall-back to only one plugin directory supported.
lbajolet-hashicorp
force-pushed
the
error_on_multiple_paths_plugin_envvar
branch
from
d9b5c4d to
f7b41b6
Compare
nywilken
reviewed
May 10, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user defines PACKER_PLUGIN_PATH in their environment, we need to error if their path defines multiple directories separated by
:.This used to be supported, but this is removed with 1.11 as we're simplifying the loading process for plugins, so we opted to fall-back to only one plugin directory supported.