hcl2template: only iterate on known HCP datasource #11883
Conversation
When we try to validate a build that contains references to hcp_packer_image, the data is not fetched, and the value is therefore unknown. However, during the decoding phase for the build blocks, we attempt to fetch the ancestry information for the current build, from the information previously fetched from HCP. Since we're validating, there's no way this is set, and attempting to cast without checking causes Packer to crash on the conversion. To avoid this, we only attempt this conversion if the value is known.
| // TODO: maybe move this HCP-related logic outside that | ||
| // decode block so it's only executed during build? | ||
| if !value.IsKnown() { |
There was a problem hiding this comment.
The information needed to deduce this association is currently only within the PackerConfig which is not directly accessible to the build command step. Originally I had this logic further up in the call stack but opted to place it here as it is dependent on the hcp packer bucket bits being available.
Not the best location for sure but hoping the code next to it provides some relevance.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
When we try to validate a build that contains references to
hcp_packer_image, the data is not fetched, and the value is therefore
unknown.
However, during the decoding phase for the build blocks, we attempt to
fetch the ancestry information for the current build, from the
information previously fetched from HCP.
Since we're validating, there's no way this is set, and attempting to
cast without checking causes Packer to crash on the conversion.
To avoid this, we only attempt this conversion if the value is known.
Closes #11870