Sanitize var code #11566
Merged
Sanitize var code #11566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be the default, and avoids a panic. This type can represent situations where a type is not yet known. Its meaning is undefined in cty.
remove untrue docs
azr
commented
Feb 14, 2022
Comment on lines
+2
to
+3
| variable "vms_to_build" { | ||
| } |
There was a problem hiding this comment.
The panic was here, because no type was given to this variable, and while trying to loop (for) on it, the HCL library would panic because the var has no type.
azr
commented
Feb 14, 2022
|
|
||
| source "file" "chocolate" { | ||
| content = "hello" | ||
| target = "${local.dynamic_slice.amgroup}.txt" |
There was a problem hiding this comment.
In the test we check that there is a hey.txt file.
2 tasks
azr
force-pushed
the
azr/simplify_recursive_var_code
branch
from
670a3d5
to
8defa43
Compare
azr
force-pushed
the
azr/simplify_recursive_var_code
branch
from
9eff32a
to
e69e839
Compare
azr
force-pushed
the
azr/simplify_recursive_var_code
branch
from
e69e839
to
a007161
Compare
Update inspect_test.go
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11554 and a panic I discovered while testing things + fixes some docs
Related: #11534
This also fixes #11551