Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: test and example tech debt #466

Merged
merged 1 commit into from
Sep 25, 2024
Merged

chore: test and example tech debt #466

merged 1 commit into from
Sep 25, 2024

Conversation

tenthirtyam
Copy link
Collaborator

Summary

Updates the tests and examples from the the original JetBrains content to generalized example content.

Testing

➜ make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        1.557s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       2.338s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       5.569s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  1.557s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   4.876s
?       github.com/hashicorp/packer-plugin-vsphere/examples/driver      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       1.399s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      1.527s

@tenthirtyam tenthirtyam added this to the v1.5.0 milestone Sep 18, 2024
@tenthirtyam tenthirtyam self-assigned this Sep 18, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner September 18, 2024 02:12
@tenthirtyam tenthirtyam marked this pull request as draft September 18, 2024 02:12
@tenthirtyam tenthirtyam force-pushed the chore/test-debt branch 2 times, most recently from 1956617 to 0978490 Compare September 18, 2024 02:16
@tenthirtyam tenthirtyam marked this pull request as ready for review September 19, 2024 00:25
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits, but overall LGTM!
I'll let you address my comments and come back later, should be near ready to merge!

Pre-approving in advance

builder/vsphere/common/testing/utility.go Show resolved Hide resolved
builder/vsphere/common/testing/utility.go Outdated Show resolved Hide resolved
builder/vsphere/driver/driver_test.go Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam force-pushed the chore/test-debt branch 2 times, most recently from 5269fff to ab6e747 Compare September 24, 2024 21:26
@tenthirtyam tenthirtyam force-pushed the chore/test-debt branch 2 times, most recently from e92207f to 4ca513d Compare September 24, 2024 21:43
@tenthirtyam
chore: test debt
2664d79 
Updates the tests and examples from the the original JetBrains content to generalized example content.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam
Copy link
Collaborator Author

Ready for review again @lbajolet-hashicorp. 😄

lbajolet-hashicorp
lbajolet-hashicorp approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks for the update @tenthirtyam!

Merging this now

@lbajolet-hashicorp lbajolet-hashicorp merged commit 3b382d2 into main Sep 25, 2024
14 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the chore/test-debt branch September 25, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Assignees

@tenthirtyam tenthirtyam

Labels
tech-debt
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@tenthirtyam @lbajolet-hashicorp