Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update version #456

Merged
merged 1 commit into from
Aug 8, 2024
Merged

chore: update version #456

merged 1 commit into from
Aug 8, 2024

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Aug 8, 2024 •
edited
Loading

Summary

  • Replaces the deprecated InitializePluginVersion with NewPluginVersion from packer-plugin-sdk, which is the recommended approach in version/version.go.
  • Removed superfluous comments that are already included in the SDK.

Testing

packer-plugin-vsphere on  chore/update-version via 🐹 v1.22.6 
➜ make dev
packer plugins install --path packer-plugin-vsphere "github.com/hashicorp/vsphere"
Successfully installed plugin github.com/hashicorp/vsphere from /Users/johnsonryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Work/packer-plugin-vsphere/packer-plugin-vsphere to /Users/johnsonryan/.packer.d/plugins/github.com/hashicorp/vsphere/packer-plugin-vsphere_v1.3.1-dev_x5.0_darwin_amd64

@tenthirtyam
chore: update version
d0cc7d4 
- Replaces the deprecated `InitializePluginVersion` with `NewPluginVersion` from `packer-plugin-sdk`, which is the recommended approach in `version/version.go`.
- Removed superfluous comments that are already included in the SDK.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added the chore Chore label Aug 8, 2024
@tenthirtyam tenthirtyam added this to the v1.3.1 milestone Aug 8, 2024
@tenthirtyam tenthirtyam self-assigned this Aug 8, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner August 8, 2024 21:33
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 8a05639 into main Aug 8, 2024
12 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the chore/update-version branch August 8, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Assignees

@tenthirtyam tenthirtyam

Labels
chore Chore
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tenthirtyam @lbajolet-hashicorp