Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support content library item uuid for hcp #438

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented May 24, 2024

Summary

If a content library item is created, that this item is used for the vsphere_uuid in HCP. Stores the content_library_item_uuid into state and uses this value if present. otherwise, it uses the default.

Testing

Basic

packer-plugin-vsphere111 git:(fix/hcp-cl-item-uuid) make generate
2024/05/24 16:28:15 Copying "docs" to ".docs/"
2024/05/24 16:28:15 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...packer-plugin-vsphere111 git:(fix/hcp-cl-item-uuid) ✗ make buildpacker-plugin-vsphere111 git:(fix/hcp-cl-item-uuid) make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        3.198s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       2.819s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       8.877s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  4.272s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   8.335s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       3.561s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      4.522s

PASS: Output Template Only

image

PASS: Output Content Library Item (Destroy Source)

image

PASS: Output Content Library Item and Keep Source Template

image

Reference

Closes #207

@tenthirtyam tenthirtyam added this to the v1.3.1 milestone May 24, 2024
@tenthirtyam tenthirtyam self-assigned this May 24, 2024
@tenthirtyam tenthirtyam added the hcp HCP-related label May 24, 2024
@tenthirtyam tenthirtyam modified the milestones: v1.3.1, On Deck May 24, 2024
@tenthirtyam tenthirtyam changed the title fix: support content library item uuid for hcp 🚧 fix: support content library item uuid for hcp May 24, 2024
@tenthirtyam tenthirtyam changed the title 🚧 fix: support content library item uuid for hcp fix: support content library item uuid for hcp May 30, 2024
@tenthirtyam tenthirtyam requested a review from nywilken May 30, 2024 21:10
@tenthirtyam tenthirtyam modified the milestones: On Deck, v1.3.1 May 30, 2024
@tenthirtyam tenthirtyam marked this pull request as ready for review May 30, 2024 21:10
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 30, 2024 21:10
If a content library item is created, that this item is used for the `vsphere_uuid` in HCP. Stores the `content_library_item_uuid` into state and uses this value if present. otherwise, it uses the default.

Signed-off-by: Ryan Johnson <[email protected]>
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for this fix.

@nywilken nywilken merged commit 597a7c8 into main Jun 12, 2024
12 checks passed
@nywilken nywilken deleted the fix/hcp-cl-item-uuid branch June 12, 2024 16:15
@hashicorp hashicorp locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug hcp HCP-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vsphere-iso: Wrong value for HCP metadata vsphere_uuid attribute when exporting to a content library
2 participants