Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix links and options #401

Merged
merged 1 commit into from
May 9, 2024
Merged

docs: fix links and options #401

merged 1 commit into from
May 9, 2024

Conversation

benjamin-lykins
Copy link
Contributor

@benjamin-lykins benjamin-lykins commented Apr 3, 2024 •
edited by tenthirtyam
Loading

Changes

  • Cleaned up Windows and Linux customization options on vsphere-clone documentation.
  • Fixed broken links for Linux and Windows options.
  • Added missing Windows options and examples.

Tests

─░▒▓    ~/git/personal/packer-plugin-vsphere  on   docs/windows_options ▓▒░·····························································································░▒▓ ✔  at 12:04:04  ▓▒░─╮
╰─ make generate                                                                                                                                                                                        ─╯
2024/04/03 12:04:21 Copying "docs" to ".docs/"
2024/04/03 12:04:21 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

╭─ ~/git/personal/packer-plugin-vsphere  on   docs/windows_options ▓▒░················································································░▒▓ ✔  took 11s   at 12:04:21  ▓▒░─╮
╰─ make test                                                                                                                                                                                            ─╯
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        2.678s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       2.080s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       5.036s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  2.208s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   4.228s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       1.436s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      2.551s

@benjamin-lykins benjamin-lykins requested a review from a team as a code owner April 3, 2024 16:09
@hashicorp-cla
Copy link

hashicorp-cla commented Apr 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

nywilken
nywilken approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @benjamin-lykins this looks good to me. I'm going to ping @tenthirtyam who has been working on a similar set of changes to get additional approval.

@tenthirtyam
Copy link
Collaborator

Let's hold until my changes in the docs/technical-debt branch are locked into a PR and merged. We can then rebased to determine any deltas.

@tenthirtyam tenthirtyam added the documentation Improvements or additions to documentation label Apr 3, 2024
@tenthirtyam tenthirtyam marked this pull request as draft April 4, 2024 18:31
@tenthirtyam
Copy link
Collaborator

Marked as draft and will rebase after my pending changes are locked in.

@tenthirtyam tenthirtyam added this to the v1.2.8 milestone Apr 9, 2024
@nywilken nywilken added the stage/waiting-on-upstream This issue is waiting on an upstream change label Apr 12, 2024
@nywilken
Copy link
Contributor

Thanks @tenthirtyam I labeled this as waiting on an upstream PR for now.

@tenthirtyam tenthirtyam self-assigned this Apr 17, 2024
@tenthirtyam tenthirtyam changed the title docs: vsphere-clone windows options and linux options docs: fix links and options Apr 19, 2024
@tenthirtyam tenthirtyam removed the stage/waiting-on-upstream This issue is waiting on an upstream change label Apr 19, 2024
@benjamin-lykins @tenthirtyam
docs: fix links and options
543ff6f 
- Cleaned up Windows and Linux customization options on `vsphere-clone` documentation.
- Fixed broken links for Linux and Windows options.
- Added missing Windows options and examples.
@tenthirtyam tenthirtyam marked this pull request as ready for review April 19, 2024 18:54
@tenthirtyam tenthirtyam removed their assignment Apr 19, 2024
@tenthirtyam tenthirtyam self-requested a review April 19, 2024 18:55
tenthirtyam
tenthirtyam approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I've pushed some minor adjustments to align with the upcoming changes that I'll working on.

@lbajolet-hashicorp lbajolet-hashicorp merged commit bf4f216 into hashicorp:main May 9, 2024
12 checks passed
@hashicorp hashicorp locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

@tenthirtyam tenthirtyam tenthirtyam approved these changes

@nywilken nywilken nywilken approved these changes

Assignees

@benjamin-lykins benjamin-lykins

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@benjamin-lykins @hashicorp-cla @tenthirtyam @nywilken @lbajolet-hashicorp