Feat/image family #138
Open
Feat/image family #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Image family support is a nice addition, however it doesn't seem to be possible to filter images by family so it's of limited use to us at the moment. |
|
Seems I was wrong, the functionality has just for some reason been moved to a separate |
Jalle19
added a commit
to Jalle19/packer-plugin-tencentcloud
that referenced
this pull request
Nov 11, 2024
|
@Jalle19 when do we expect this pull request to be accepted ? |
|
It's not up to me |
|
Hi, could we have this reviewed please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DELETE THIS TEMPLATE BEFORE SUBMITTING
In order to have a good experience with our community, we recommend that you
read the contributing guidelines for making a PR, and understand the lifecycle
of a Packer Plugin PR:
https://github.com/hashicorp/packer-plugin-tencentcloud/blob/main/.github/CONTRIBUTING.md#opening-an-pull-request
Describe the change you are making here!
Please include tests. We recommend looking at existing tests as an example.
If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged:
Closes #xxx
Closes #xxx