Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA migration finalisation #172

Merged
merged 4 commits into from
Apr 12, 2023
Merged

GHA migration finalisation #172

merged 4 commits into from
Apr 12, 2023

Conversation

lbajolet-hashicorp
Copy link
Contributor

As part of the ongoing efforts to migrate from Circle CI to GHA, this PR pins the external actions to a SHA, adds actionlint to the repo, and fixes permissions for actions that didn't have it yet.

@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner April 12, 2023 17:27
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I left a question about the permissions for the actionlint but seeing as this was tested elsewhere I just might be overly cautious because of the ghrc.io permissions.

@lbajolet-hashicorp lbajolet-hashicorp force-pushed the gha-migration-finalise branch 2 times, most recently from b92ddc3 to 7bf65f8 Compare April 12, 2023 18:59
@lbajolet-hashicorp lbajolet-hashicorp force-pushed the gha-migration-finalise branch 2 times, most recently from 89c447f to b102c24 Compare April 12, 2023 19:14
@lbajolet-hashicorp lbajolet-hashicorp merged commit 9b87bcd into main Apr 12, 2023
@lbajolet-hashicorp lbajolet-hashicorp deleted the gha-migration-finalise branch April 12, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants