Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell-local: fix supported_os error check #155

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

lbajolet-hashicorp
Copy link
Contributor

Commit 34ed5d9 which consists of linting fixes essentially had an error in the code and the error check for `supported_os' was inverted in this commit, making shell-local fail on all supported OSes now.

We re-invert this condition so it behaves as it used to.

Commit 34ed5d9 which consists of linting fixes essentially had an
error in the code and the error check for `supported_os' was inverted in
this commit, making shell-local fail on all supported OSes now.

We re-invert this condition so it behaves as it used to.
@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner January 27, 2023 13:57
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the quick fix.

@lbajolet-hashicorp lbajolet-hashicorp merged commit 6f32b7f into main Jan 27, 2023
@nywilken nywilken deleted the fix_supported_os_check branch January 27, 2023 16:37
@nywilken nywilken added the bug Something isn't working label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants