Remove ioutil in favour of io and os packages and exclude crypto/dsa … #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from linting as the warning is not relevant.
|
@lbajolet-hashicorp Poking you now this is not WIP :P |
lbajolet-hashicorp
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Hi @rossmaclean,
Thanks for the lint pass on the codebase here, much appreciated!
I just left a comment on the DSA issue being deprecated, it wasn't clear at first why the nolint:all directives were added to the package imports, so I suggested leaving a warning in the documentation to make it clear why it is marked as such.
Other than that, it all looks good to me, thanks again for the PR!
nywilken
approved these changes
Feb 1, 2023
nywilken
added
the
tech-debt
Co-authored-by: Lucas Bajolet <[email protected]>
|
Thanks both for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the ioutil package as suggested by the linter in favour of the io and os packages. Also fixes other linting warnings.