Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Change down to highest-priority composite status #9927

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Jan 29, 2021

As pointed out by @nickethier, if a node was ineligible before
it went down, downness should be displayed, not ineligibility.

@github-actions
Copy link

github-actions bot commented Jan 29, 2021

Ember Asset Size action

As of 9adfcf7

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +27 B +11 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

As pointed out by Nick Ethier, if a node was ineligible before
it went down, downness should be displayed, not ineligibility.
@github-actions
Copy link

github-actions bot commented Jan 29, 2021

Ember Test Audit comparison

master 9adfcf7 change
passes 1550 1550 0
failures 0 0 0
flaky 0 0 0
duration 7m 03s 361ms 6m 59s 906ms -03s 455ms

@github-actions
Copy link

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on 6cbed10510cf4475c96fb52b2e151ca51bfc37b9:

  • Acceptance | client detail: the status light indicates when the node is ineligible for scheduling

Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@backspace backspace merged commit e28cb14 into master Feb 1, 2021
@backspace backspace deleted the b-ui/client-down-over-ineligible branch February 1, 2021 18:00
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants