UI: Use server-sent error messages when applicable #9909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Asset Size actionAs of 3aa4cf3 Files that got Smaller 🎉:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
DingoEatingFuzz
force-pushed
the
b-ui/incorrect-error-message
branch
from
27b2a80 to
44e164c
Compare
backspace
suggested changes
Jan 28, 2021
| @@ -85,7 +86,7 @@ export default class IndexController extends Controller.extend(Sortable) { | |||
| } catch (err) { | |||
| this.set('error', { | |||
| title: 'Could Not Restart Allocation', | |||
| description: 'Your ACL token does not grant allocation lifecycle permissions.', | |||
| description: messageForError(err, 'manage allocation life cycle'), | |||
There was a problem hiding this comment.
The documentation seems to consistently use lifecycle vs life cycle, should this too?
Automatically detect ACL errors Provide a generic error message as a fallback
When the error is actually a 403, an ACL error is appropriate, but when it isn't, fallback on what the API returns.
DingoEatingFuzz
force-pushed
the
b-ui/incorrect-error-message
branch
from
44e164c to
5dfa556
Compare
|
Okay! I reverted the |
backspace
approved these changes
Jan 28, 2021
|
Oh! I like that idea. It also doubles as evidence in the UI code that we expect plain text responses from errors. |
backspace
added a commit
that referenced
this pull request
Feb 10, 2021
This is a supplement to #9831 to incorporate the extracted missing-permissions error handling from #9909. It fixes this failure on the main branch! 😳 https://app.circleci.com/pipelines/github/hashicorp/nomad/14728/workflows/4c147dca-fd1e-4de7-86aa-90ded7aabad2/jobs/137137
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7875
In most places in the UI, the error message shown after failed actions is a mostly generic "Your ACL token said no" message. Sometimes this occludes genuine and helpful 500 error messages being returned from the API.
This makes it so anywhere we show an error message we make sure to only show an ACL error message if it is a 403 error, otherwise just print what the API gave us.