csi: Return error when deleting node #9803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error that this would have returned would only have been returned if the lookup in a map did not fail and the value that the map returned was nil, which I think is not possible. In this change we'll properly return the error in the CSIPluginTypeMonolith case (which is the type given in DeleteNode()), and also actually return the error when the given ID is not found. This was found via errcheck.
tgross
requested changes
Jan 13, 2021
These tests were backfilled and run against the original implementation before the updated implementation was restored and modified to fix the prev == nil check. Additional behavior was added to return a multierror in the case of CSIPluginTypeMonolith, with associated tests added, too.
backspace
pushed a commit
that referenced
this pull request
Jan 22, 2021
In this change we'll properly return the error in the CSIPluginTypeMonolith case (which is the type given in DeleteNode()), and also return the error when the given ID is not found. This was found via errcheck.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error that this would have returned would only have been returned if
the lookup in a map did not fail and the value that the map returned was
nil,
which I think is not possiblethe map keys are pointers, so they can be!In this change we'll properly return the error in the
CSIPluginTypeMonolith case (which is the type given in DeleteNode()),
and also actually return the error when the given ID is not found.
This was found via errcheck.
Note:
Since I don't think it was possible for this to have ever actually returned an error before,I wonder if the behavior when trying to delete a node where one of the controller or node is not found should actually return an error, and if so, if it should only do so for one and not the other. In other words, if you want to delete a node and there's no controller found, should it still proceed to try deleting the node from the map?