Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Moe unquoting of HCL block attributes #9612

Merged
merged 5 commits into from
Dec 10, 2020
Merged

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Dec 10, 2020

Tweak the docs for some HCL2 changes: update remaining examples that still quoted env/meta keys, remove var-file reference (until #9592 ships), and note that env/meta keys need to be valid identifiers.

Mahmood Ali added 4 commits December 10, 2020 11:30
@notnoop notnoop requested a review from shoenig December 10, 2020 17:13
@notnoop notnoop changed the title Moe unquoting of HCL block attributes docs: Moe unquoting of HCL block attributes Dec 10, 2020
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just the minor suggestions

website/pages/docs/job-specification/hcl2/index.mdx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – nomad-storybook-and-ui December 10, 2020 17:21 Inactive
@notnoop notnoop merged commit 7af6669 into master Dec 10, 2020
@notnoop notnoop deleted the docs-hcl2-tweaks branch December 10, 2020 17:21
schmichael pushed a commit that referenced this pull request Dec 16, 2020
docs: Moe unquoting of HCL block attributes
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants