Add gosimple linter #9590
Add gosimple linter #9590
Conversation
| @@ -65,14 +65,12 @@ func (m *PluginGroup) WaitForFirstFingerprint(ctx context.Context) (<-chan struc | |||
| go func() { | |||
| defer wg.Done() | |||
| logger.Debug("waiting on plugin manager initial fingerprint") | |||
| <-manager.WaitForFirstFingerprint(ctx) | |||
There was a problem hiding this comment.
Does WaitForFirstFingerprint have a side-effect? I'd have thought we'd want something more like:
select {
case <- manager.WaitForFirstFingerprint(ctx):
logger.Debug("finished plugin manager initial fingerprint")
case <-ctx.Done():
logger.Warn("timeout waiting for plugin manager to be ready")
}There was a problem hiding this comment.
My goal here was not to change the behavior; are you saying you think it has changed, or that we should introduce this change?
There was a problem hiding this comment.
I was saying that as long as we're touching this code we should introduce this change and fix what looks like a minor bug. But that's a good point... maybe that should be under separate PR so that it's not getting lost in this linter PR.
As pointed out by [@tgross](#9590 (comment)), prior to this change we would have been blocking until all managers waited for first fingerprint rather than timing out as intended.
As pointed out by @tgross[1], prior to this change we would have been blocking until all managers waited for first fingerprint rather than timing out as intended. 1: #9590 (comment)
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.