Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Remove support for IE11 #9578

Merged
merged 1 commit into from
Feb 2, 2021
Merged

UI: Remove support for IE11 #9578

merged 1 commit into from
Feb 2, 2021

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Dec 8, 2020 •
edited
Loading

This changes the Babel compilation targets to exclude IE, which results in significant payload size savings.

Thanks to @pichfl for this solution to an Uglify problem.

@backspace
Remove support for IE11
22491a9 
This is another angle on #9577, since the helpers in question
there are only present for IE.

Thanks to @pichfl for this solution to an Uglify problem.
@backspace backspace self-assigned this Dec 8, 2020
@github-actions
Copy link

github-actions bot commented Dec 8, 2020

Ember Asset Size action

As of 22491a9

Files that got Smaller 🎉:

File raw gzip
nomad-ui.js -608 kB -43.4 kB
vendor.js -183 kB -19.1 kB

Files that stayed the same size 🤷‍:

File raw gzip
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Dec 8, 2020

Ember Test Audit comparison

master 22491a9 change
passes 1541 1541 0
failures 0 0 0
flaky 0 0 0
duration 7m 01s 960ms 7m 00s 968ms -992ms

@backspace backspace marked this pull request as ready for review February 2, 2021 17:12
@backspace backspace mentioned this pull request Feb 2, 2021
Closed
DingoEatingFuzz
DingoEatingFuzz reviewed Feb 2, 2021
View reviewed changes
Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious file size savings ✨

DingoEatingFuzz
DingoEatingFuzz approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, missed a step. ✅

@backspace backspace merged commit 4e0e33e into master Feb 2, 2021
@backspace backspace deleted the f-ui/byie branch February 2, 2021 19:14
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DingoEatingFuzz DingoEatingFuzz DingoEatingFuzz approved these changes

Assignees

@backspace backspace

Labels
theme/cleanup theme/ui type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@backspace @DingoEatingFuzz