Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Simplify README #9378

Merged
merged 1 commit into from
Nov 17, 2020
Merged

doc: Simplify README #9378

merged 1 commit into from
Nov 17, 2020

Conversation

krishicks
Copy link
Contributor

This is mostly switching paragraphs to bullets to make following
instructions easier. In doing so, this also adds instructions to install
things that were previously assumed to be installed, like Vagrant,
Virtualbox, and Consul.

It also removes the expectation that Nomad is cloned to $GOPATH, as that
is not necessary.

This is mostly switching paragraphs to bullets to make following
instructions easier. In doing so, this also adds instructions to install
things that were previously assumed to be installed, like Vagrant,
Virtualbox, and Consul.

It also removes the expectation that Nomad is cloned to $GOPATH, as that
is not necessary.
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

1. Compile a development binary (see the [UI README](https://github.com/hashicorp/nomad/blob/master/ui/README.md) to include the web UI in the binary)
```sh
$ make dev
# find the built binary at ./bin/nomad
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this path is coming from the previous version of the directions, but I think it ends up at ~/go/bin/nomad by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets installed to multiple places by default:

  • ./bin/nomad
  • ./pkg/$GOOS_$GOARCH/nomad
  • $GOPATH/bin/nomad

See https://github.com/hashicorp/nomad/blob/master/GNUmakefile#L288.

There's no real need for it to be installed into $GOPATH/bin, except that people may be depending on $GOPATH/bin having been added to their $PATH as a way to run a dev build.

Copy link
Member

@tgross tgross Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh? (Rummages around on file system) 🤦 sure does, doesn't it! LGTM

@krishicks krishicks merged commit 8f18856 into master Nov 17, 2020
@krishicks krishicks deleted the hicks/readme branch November 17, 2020 19:20
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants