csi: Postrun hook should not change mode #9323
Conversation
The unpublish workflow requires that we know the mode (RW vs RO) if we want to unpublish the node. Update the hook and the Unpublish RPC so that we mark the claim for release in a new state but leave the mode alone. This fixes a bug where RO claims were failing node unpublish. The core job GC doesn't know the mode, but we don't need it for that workflow, so add a mode specifically for GC; the volumewatcher uses this as a sentinel to check whether claims (with their specific RW vs RO modes) need to be claimed.
| // COMPAT(1.0): the NodeID field was added after 0.11.0 and so we | ||
| // need to ensure it's been populated during upgrades from 0.11.0 | ||
| // to later patch versions. Remove this block in 1.0 | ||
| if args.Claim != structs.CSIVolumeClaimRelease && args.NodeID == "" { | ||
| if isNewClaim && args.NodeID == "" { |
There was a problem hiding this comment.
nit: un-touched in this PR but GH is displaying it, if a watchset is never used nil can be used instead https://github.com/hashicorp/nomad/pull/9323/files#diff-6a3c30b17bb256ab9e3d5bab1620c3b9afee29aaa06371eae6cae0951a2fb12aL376
There was a problem hiding this comment.
Cool, thanks! I have another PR I'm working on that'll touch that area of code, so I'll fix it in that one.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #9259
The unpublish workflow requires that we know the mode (RW vs RO) if we want to
unpublish the node. Update the hook and the Unpublish RPC so that we mark the
claim for release in a new state but leave the mode alone. This fixes a bug
where RO claims were failing node unpublish.
The core job GC doesn't know the mode, but we don't need it for that workflow,
so add a mode specifically for GC; the volumewatcher uses this as a sentinel
to check whether claims (with their specific RW vs RO modes) need to be claimed.