Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add policy list and info to new scaling cmd. #9025

Merged
merged 2 commits into from
Oct 6, 2020
Merged

cli: add policy list and info to new scaling cmd. #9025

merged 2 commits into from
Oct 6, 2020

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Oct 5, 2020

This adds the ability to detail scaling policies via the CLI.

Relates #8649
Docs to be added in future PR.

@jrasell
cli: add policy list and info to new scaling cmd.
13466a9 
This adds the ability to detail scaling policies via the CLI.
@jrasell jrasell added this to the 0.13 milestone Oct 5, 2020
@jrasell jrasell requested review from lgfa29 and cgbaker October 5, 2020 13:29
@jrasell jrasell self-assigned this Oct 5, 2020
cgbaker
cgbaker approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lgfa29
lgfa29 approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

One thing I noticed is that the commands don't support Namespaces. We can add that in a follow-up PR though. Nope. I just don't know how to use the CLI.

It would be nice to have ID prefix matching as well, but that's more of a change in the api than here.

command/scaling_policy_info.go Show resolved Hide resolved
command/scaling_policy_list.go Show resolved Hide resolved
command/scaling_policy_info.go Show resolved Hide resolved
@jrasell jrasell mentioned this pull request Oct 6, 2020
Closed
12 tasks
@vercel
Copy link

vercel bot commented Oct 6, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hashicorp/nomad/gx69wvx1h
✅ Preview: https://nomad-git-f-gh-8649.hashicorp.vercel.app

@jrasell jrasell merged commit ca8b4f6 into master Oct 6, 2020
@jrasell jrasell deleted the f-gh-8649 branch October 6, 2020 10:40
jrasell added a commit that referenced this pull request Oct 6, 2020
@jrasell
changelog: add entries for #9023 and #9025
1502941
jrasell added a commit that referenced this pull request Oct 6, 2020
@jrasell
Merge pull request #9037 from hashicorp/f-changelog-entries-9023-9025
9609ee7 
changelog: add entries for #9023 and #9025
fredrikhgrelland pushed a commit to fredrikhgrelland/nomad that referenced this pull request Oct 22, 2020
@jrasell @fredrikhgrelland
changelog: add entries for hashicorp#9023 and hashicorp#9025
ad284b8
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgfa29 lgfa29 lgfa29 approved these changes

@cgbaker cgbaker cgbaker approved these changes

Assignees

@jrasell jrasell

Labels
theme/cli type/enhancement
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jrasell @lgfa29 @cgbaker