drivers/docker/driver.go: change default signal for docker driver to SIGTERM? #8933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jf
force-pushed
the
fix_docker_stopsignal
branch
from
9fef312 to
84e5907
Compare
shoenig
approved these changes
Sep 29, 2020
fredrikhgrelland
pushed a commit
to fredrikhgrelland/nomad
that referenced
this pull request
Oct 22, 2020
This PR adds a version specific upgrade note about the docker stop signal behavior. Also adds test for the signal logic in docker driver. Closes hashicorp#8932 which was fixed in hashicorp#8933
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial #8932 (needs docs)
NOTE: I'm guessing ideally, the standard messaging in various places (
nomad/structs/structs.go,command/alloc_status.go) with text like 'Sent interrupt' might have to change as well, but maybe that can be part of a bigger discussion. For now, I think updating the default from SIGINT to SIGTERM makes sense.References: https://www.nomadproject.io/docs/job-specification/task#kill_signal, https://docs.docker.com/engine/reference/commandline/stop/