Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Task lifecycle poststop phase. #8807

Merged
merged 2 commits into from
Nov 12, 2020
Merged

UI: Task lifecycle poststop phase. #8807

merged 2 commits into from
Nov 12, 2020

Conversation

DingoEatingFuzz
Copy link
Contributor

This brings back the poststop phase extracted from #8742.

It also fixes the two flaky tests and the one typo'd assertion.

@DingoEatingFuzz DingoEatingFuzz added this to the 0.13 milestone Sep 1, 2020
@DingoEatingFuzz DingoEatingFuzz marked this pull request as draft September 1, 2020 17:09
@github-actions
Copy link

github-actions bot commented Sep 1, 2020 •
edited
Loading

Ember Asset Size action

As of 99244af

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +255 B +29 B
nomad-ui.css +134 B +11 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Sep 1, 2020 •
edited
Loading

Ember Test Audit comparison

master 99244af change
passes 1536 1536 0
failures 0 0 0
flaky 0 0 0
duration 7m 19s 793ms 9m 01s 496ms +1m 41s 703ms

backspace
backspace approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for attending to this in my absence!

@DingoEatingFuzz DingoEatingFuzz marked this pull request as ready for review November 12, 2020 17:04
@DingoEatingFuzz DingoEatingFuzz merged commit b487f40 into master Nov 12, 2020
@DingoEatingFuzz DingoEatingFuzz deleted the f-ui/lifecycle-poststop branch November 12, 2020 17:50
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jazzyfresh jazzyfresh jazzyfresh approved these changes

@backspace backspace backspace approved these changes

Assignees
No one assigned
Labels
theme/ui
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DingoEatingFuzz @backspace @jazzyfresh