Decrease size of Allocation when serializing #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,8 +58,20 @@ func AllocsFit(node *Node, allocs []*Allocation, netIdx *NetworkIndex) (bool, st | |||
|
|
|||
| // For each alloc, add the resources | |||
| for _, alloc := range allocs { | |||
| if err := used.Add(alloc.Resources); err != nil { | |||
| return false, "", nil, err | |||
| if alloc.Resources != nil { | |||
There was a problem hiding this comment.
Do we need this at all? Can't we always re-build?
There was a problem hiding this comment.
After it is built once it is stored in memory to save compute time.
|
LGTM overall. |
dadgar
added a commit
that referenced
this pull request
Mar 1, 2016
Decrease size of Allocation when serializing
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR causes the scheduler to not add the following to Allocations:
These result in a roughly 15% size reduction of the AllocUpdateRequest.
We should look into having the stack not return the size as it is no longer being used.
cc: @armon