UI: Add linting to check for acceptance accessibility audits #8570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has exclusions for the filesystem browser tests. Linting will fail because the search test doesn’t have an audit.
I thought I could address this but it seems like it’ll entail overriding more Ember Power Select templates, so I’ll come back to it separately.
Ember Asset Size actionAs of b5d4e3e Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the PR I recently had merged to
eslint-plugin-ember-a11y-testingto add linting that ensures an accessibility audit is called at least once per acceptance test file. When I have added linting for component tests, it can apply there too.I added exclusions for the filesystem browser tests, which are covered by
behaviors/fsand for the search test which will involve significant overrides to Ember Power Select default templates.