Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format job init hcl #8483

Merged
merged 1 commit into from
Jul 21, 2020
Merged

format job init hcl #8483

merged 1 commit into from
Jul 21, 2020

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Jul 21, 2020

Fixes #8109

@notnoop notnoop requested a review from drewbailey July 21, 2020 15:43
drewbailey
drewbailey approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@drewbailey drewbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't quite follow why some fields are commented and others are not as a whole, but this diff seems good

@notnoop
Copy link
Contributor Author

notnoop commented Jul 21, 2020

Me neither - I'm guessing it's related to how often a field is used which influences whether it's turned on by default...

@notnoop notnoop merged commit 133e93e into master Jul 21, 2020
@notnoop notnoop deleted the b-init-formatting branch July 21, 2020 15:49
@notnoop notnoop added this to the 0.12.1 milestone Jul 21, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drewbailey drewbailey drewbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.

nomad init hcl is misformatted
2 participants
@notnoop @drewbailey