Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable dynamic port range #8478

Closed
wants to merge 1 commit into from

Conversation

prestonp
Copy link

The intent of this change is to support shifting the range used for assigning dynamic ports (#8186).

This makes the static dynamic port range configurable per new client settings dynamic_port_range_min and dynamic_port_range_max.

The intent of this change is to support shifting the range used for assigning dynamic ports (hashicorp#8186).

This makes the static dynamic port range configurable per new client settings `dynamic_port_range_min` and `dynamic_port_range_max`.
@prestonp prestonp force-pushed the prestonp/dynamic-port-cfg branch from 89759b3 to 24dd800 Compare August 5, 2020 10:10
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prestonp! Thanks for submitting this PR!

This probably works ok for a single-node cluster that's both a server and client, but it looks like it'll break down in a production environment with multiple nodes.

You have the dynamic port range is configured on a per-client basis, which definitely is the right thing to do because different clients will have different non-Nomad-managed services. But then the server doesn't have any way of handling that information on a per-client basis for scheduling purposes; there's only the global in structs/network.go. So when AssignPorts gets called by the scheduler, it'll always get the same answer.

The dynamic port range needs to be added to the Node struct so that it can be passed up from the client to the server with the fingerprint in node_updater.go.

@jrasell
Copy link
Member

jrasell commented Oct 28, 2021

This functionality was added within #11167 and will be released in Nomad 1.2.0.

@jrasell jrasell closed this Oct 28, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants