UI: Update to Ember 3.16/Data 3.12 #8319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Asset Size actionAs of 66e55aa Files that got Bigger 🚨:
Files that got Smaller 🎉:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
Some interventions: * changing template lint back to “recommended” vs “octane” * returning Ember Data to 3.12 * deleted config/ember-cli-update.json
backspace
force-pushed
the
f-ui/ember-3.16-lts-redux
branch
from
d8a439f to
cb884b7
Compare
This was throwing an error trying to fetch a non-existent id.
The ClientDetail.attributesTable assertion was failing because it becoming a template-only component meant that the data-test-attributes selector had no element to attach to. Having the edition set to Octane in package.json causes an error to be thrown when template-only-glimmer-components is turned off, so it’ll have to go for now.
This is mostly a direct replacement of partials with components. In some cases, the components needed a layout or injected services that were formerly available via containing scope.
backspace
force-pushed
the
f-ui/ember-3.16-lts-redux
branch
from
cb884b7 to
66e55aa
Compare
20 tasks
DingoEatingFuzz
approved these changes
Jul 9, 2020
|
|
||
| @tagName('') | ||
| export default class SvgPatterns extends Component { | ||
| } |
There was a problem hiding this comment.
Wow, I haven't thought about this partial in awhile.
| @@ -7,5 +7,6 @@ self.deprecationWorkflow.config = { | |||
| { handler: 'throw', matchId: 'ember-console.deprecate-logger' }, | |||
| { handler: 'throw', matchId: 'ember-test-helpers.rendering-context.jquery-element' }, | |||
| { handler: 'throw', matchId: 'ember-cli-page-object.is-property' }, | |||
| { handler: 'throw', matchId: 'ember-views.partial' }, | |||
backspace
added a commit
that referenced
this pull request
Jul 13, 2020
This updates the Ember edition setting to Octane, which I removed from #8319 because it required the template-only Glimmer components setting to be turned on, which this does. These changes to templates accommodate that setting.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to Ember 3.16 but leaves Ember Data at 3.12 so we don’t need
to use the model fragments beta. It can be reviewed on a commit-by-commit
basis: blueprint updates, fixes for test failures, and the removal of
now-deprecated partials.
It’s not a true update to Octane as that would involve turning on template-only
components by default, which breaks various things. We can accomplish that
separately and then add the edition setting to
package.json.