-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Improve global search UX #8249
Conversation
This makes things a bit off in all the browser’s I’ve checked with so it needs some tweaking.
Maybe this fixes the click-doesn’t-open-search problem?
Ember Asset Size actionAs of fd39ead Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
This uses a hacked version of Ember Power Select that adds another option to its public API: setIsActive. This allows me to check whether the escape key is what led to a close event and change the control to be inactive if so.
51b9e96
to
a940fe1
Compare
Maybe the problem was a double-open?
9eed9fa
to
f892486
Compare
This causes it to run into the navigation elements so maybe I’ll hide it at a wider breakpoint? 🧐
I don’t love the look of this… adapted from learn.hashicorp.com but the colour scheme seems less favourable 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice collection of improvements.
The fork is of course unfortunate. Hopefully that can be handled upstream at some point.
The result highlighting is also a little funky. It doesn't always highlight the text I would expect. But short of doing what github's file fuzzy search does (break the search term into chunks and highlight multiple substrings) I think this is the best we can get.
The border around the search input in the dormant state is better now, but I think it might still be too much. The contrast draws a lot of attention to it when I think it would be okay for it to fall into the background a bit more. The original design for this had it borderless when idle.
As for the shortcut icon, I think it may be suffering the same border problem where it's drawing a lot of focus by the sharp lines. Maybe a dark green "/" on a light green, rounded background?
These are just things to think about between now and RC, definitely not blocking this on that 🙂
Thanks for the styling suggestions, I meant to refer back to the original design but failed to in the press for time. I think it looks much better now! Re fuzzy search highlighting expectations, it should be possible to have multiple highlights instead of only using the first. Can you give an example of not highlighting what you would expect? I think this would be a minimal intervention before the RC 🤞 |
excellent, thanks, I can definitely refine the |
The CSS I added in #8249 to make the search be properly centred also made the logo unclickable as it was hidden behind the centred element! This makes the logo stay above the search container.
The CSS I added in #8249 to make the search be properly centred also made the logo unclickable as it was hidden behind the centred element! This makes the logo stay above the search container.
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This has a few improvements to the search: