Revert "client: defensive against getting stale alloc updates" #8217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5906
This reverts a defensive check against leaders violating a monotonic consistency where leaders returned stale data. Well, now this can happen due to snapshot restore to a previous time.
Note that we haven't observed this issue in any setup outside single dev instance clusters, and the actual underlying issue has been addressed in #5911 .
I have considered adding a more sophisticated way to have clients detect if state got reverted manually but decided against it, because the underlying issues were already addressed and I worry that any additional sophisticated checks will be additional complexity that can have more damaging effects. Sample abandoned consideration: if a client notices a rollback of index, wait for N seconds before trusting value and killing local allocs; have server RPC return overall server index and have client compare the two if there is a discrepancy.