Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "client: defensive against getting stale alloc updates" #8217

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Jun 19, 2020

Reverts #5906

This reverts a defensive check against leaders violating a monotonic consistency where leaders returned stale data. Well, now this can happen due to snapshot restore to a previous time.

Note that we haven't observed this issue in any setup outside single dev instance clusters, and the actual underlying issue has been addressed in #5911 .

I have considered adding a more sophisticated way to have clients detect if state got reverted manually but decided against it, because the underlying issues were already addressed and I worry that any additional sophisticated checks will be additional complexity that can have more damaging effects. Sample abandoned consideration: if a client notices a rollback of index, wait for N seconds before trusting value and killing local allocs; have server RPC return overall server index and have client compare the two if there is a discrepancy.

@notnoop notnoop added this to the 0.12.0-beta1 milestone Jun 19, 2020
@notnoop notnoop requested a review from schmichael June 19, 2020 19:45
@notnoop notnoop self-assigned this Jun 19, 2020
@notnoop notnoop merged commit 0bfe89c into master Jun 19, 2020
@notnoop notnoop deleted the revert-5906-b-alloc-stale-updates branch June 19, 2020 21:02
@github-actions
Copy link

github-actions bot commented Jan 2, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants