Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: canonicalize connect components #8018

Merged
merged 2 commits into from
May 26, 2020
Merged

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented May 19, 2020

Add Canonicalize methods to the connect components of a service definition in the api package. Without these, we have been relying on good input for the connect stanza.

Fixes #7993

shoenig added 2 commits May 19, 2020 11:47
Add `Canonicalize` methods to the connect components of a service
definition in the `api` package. Without these, we have been relying
on good input for the connect stanza.

Fixes #7993
@shoenig shoenig requested review from schmichael and nickethier May 19, 2020 18:51
Copy link
Member

@nickethier nickethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shoenig shoenig merged commit bc72de5 into master May 26, 2020
@shoenig shoenig deleted the b-sidecar-task-resources-npe branch May 26, 2020 14:19
@cgbaker
Copy link
Contributor

cgbaker commented May 30, 2020

cherry-picked into 0.11.3

cgbaker pushed a commit that referenced this pull request May 30, 2020
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set resources for sidecar tasks
3 participants