csi: make volume GC in job deregister safely async #7632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
csi_avoid_blocking_deregister
branch
2 times, most recently
from
bf8e1ec to
b4ae84b
Compare
|
Passing e2e: |
tgross
force-pushed
the
csi_avoid_blocking_deregister
branch
from
b4ae84b to
d569d6a
Compare
langmartin
approved these changes
Apr 6, 2020
The CSI plugins uses the external volume ID for all operations, but the Client CSI RPCs uses the Nomad volume ID (human-friendly) for the mount paths. Pass the External ID as an arg in the RPC call so that the unpublish workflows have it without calling back to the server to find the external ID. The controller CSI plugins need the CSI node ID (or in other words, the storage provider's view of node ID like the EC2 instance ID), not the Nomad node ID, to determine how to detach the external volume.
The `Job.Deregister` call will block on the client CSI controller RPCs while the alloc still exists on the Nomad client node. So we need to make the volume claim reaping async from the `Job.Deregister`. This allows `nomad job stop` to return immediately. In order to make this work, this changeset changes the volume GC so that the GC jobs are on a by-volume basis rather than a by-job basis; we won't have to query the (possibly deleted) job at the time of volume GC. We smuggle the volume ID and whether it's a purge into the GC eval ID the same way we smuggled the job ID previously.
tgross
force-pushed
the
csi_avoid_blocking_deregister
branch
from
d569d6a to
97f1ccd
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #7629
Includes commits from #7628
The
Job.Deregistercall will block on the client CSI controller RPCs while the alloc still exists on the Nomad client node. So we need to make the volume claim reaping async from theJob.Deregister. This allowsnomad job stopto return immediately. In order to make this work, I've changed the volume GC so that the GC jobs are on a by-volume basis rather than a by-job basis; we won't have to query the (possibly deleted) job at the time of volume GC. I'm smuggling the volume ID and whether it's a purge into the GC eval ID the same way we smuggled the job ID previously.This doesn't entirely fix #7629 because the first GC attempt for volumes with a controller with fail and be re-queued. I've decreased the client-side controller timeout to reduce the wait time as a stop-gap, but we'll want to revisit it.
This leaves the E2E tests with
nomad stop -purgeflaky, depending on timing. For now I've changed them so as not to purge until we've corrected the problem more permanently.