csi: add grpc retries to client controller RPCs #7549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add grpc retries with backoff to `ControllerPublishVolume`, `ControllerUnpublishVolume`, and `VolumeValidateCapabilities`.
This was referenced Mar 30, 2020
tgross
commented
Mar 30, 2020
| // as fatal. | ||
| // In the future, we can provide more useful error messages based on | ||
| // different types of error. For error documentation see: | ||
| // https://github.com/container-storage-interface/spec/blob/4731db0e0bc53238b93850f43ab05d9355df0fd9/spec.md#nodestagevolume-errors |
There was a problem hiding this comment.
ref #7424 for where this extra info went
This was referenced Mar 30, 2020
langmartin
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
This looks good! My only concern was the missing data, I added a comment to #7424 about getting ResourceExhausted back to the CSIVolume struct.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6863
The CSI Specification defines various gRPC Errors and how they may be retried. After auditing all our CSI RPC callas in #6863 (comment), this changeset:
Probecall, which didn't have one.