Docker 19.03.8 #7351
Closed
Docker 19.03.8 #7351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoan Blanc <[email protected]>
Looks like the latest `github.com/docker/docker/registry.ResolveAuthConfig` expect `github.com/docker/docker/api/types.AuthConfig` rather than `github.com/docker/cli/cli/config/types.AuthConfig`. The two types are identical but live in different packages. Here, we embed `registry.ResolveAuthConfig` from upstream repo, but with the signature we need.
Signed-off-by: Yoan Blanc <[email protected]>
|
it needs that one, moby/moby#40021 |
Signed-off-by: Yoan Blanc <[email protected]>
|
At some point, wouldn't it be easier to have docker as a separated plugin? |
|
Having Docker as external plugin would be huge :) |
Merged
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to #7350
docker's is incompatible withgolang.org/x/sys/windowswhich is required bygopsutils.mobyshould upgrade to a fresher version. (or I'm doing it wrong and it's much easier than that)