Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csi: Add /dev mounts to CSI Plugins #7215

Merged
merged 1 commit into from
Feb 21, 2020
Merged

csi: Add /dev mounts to CSI Plugins #7215

merged 1 commit into from
Feb 21, 2020

Conversation

endocrimes
Copy link
Contributor

CSI Plugins that manage devices need not just access to the CSI
directory, but also to manage devices inside /dev.

This commit introduces a /dev:/dev mount to the container so that they
may do so.

@endocrimes
csi: Add /dev mounts to CSI Plugins
56d25ee 
CSI Plugins that manage devices need not just access to the CSI
directory, but also to manage devices inside `/dev`.

This commit introduces a `/dev:/dev` mount to the container so that they
may do so.
@endocrimes endocrimes requested a review from tgross February 21, 2020 10:47
@tgross
Copy link
Member

tgross commented Feb 21, 2020

This is specifically to support #7139, right? I think I want to wait to try to do this until we have both ACLs figured out entirely and have decided whether we're going to try to land #7139 in 0.11.0 or not.

@endocrimes
Copy link
Contributor Author

@tgross nope - this is needed for most CSI plugins tbh - they'll take the attached disk, and handle formatting and mounting as a file system (I found it while building the DO demo)

@endocrimes endocrimes added this to the 0.11.0 milestone Feb 21, 2020
tgross
tgross approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As we discussed in chat, CSI plugins are going to be privileged anyways so it's doesn't really expand our attack surface to do this.

@endocrimes endocrimes merged commit 1408970 into f-csi-volumes Feb 21, 2020
@endocrimes endocrimes deleted the f-dev-mount branch February 21, 2020 15:14
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
theme/storage
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@endocrimes @tgross