Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Override the max-width on mobile to avoid losing space due to non-existent gutter menu #7099

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

DingoEatingFuzz
Copy link
Contributor

At some point we switched to max-width to subtract the gutter menu width but didn't adjust the property within the media query to match. The result is that even when the gutter menu is collapsed, the main page body is subtracting width.

Before
Screen Shot 2020-02-07 at 2 21 08 PM

After:
image

Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, much better, thank you 😀

@DingoEatingFuzz DingoEatingFuzz merged commit 4757f87 into master Feb 7, 2020
@DingoEatingFuzz DingoEatingFuzz deleted the b-ui/mobile-styles-not-full-width branch February 7, 2020 22:27
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants