Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab bag of dev tweaks #7055

Merged
merged 5 commits into from
Feb 3, 2020
Merged

Grab bag of dev tweaks #7055

merged 5 commits into from
Feb 3, 2020

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Feb 3, 2020

Some changes that helped me a tiny bit in development. Best reviewed commit by commit.

Mahmood Ali added 5 commits February 3, 2020 11:26
Avoid Vagrant/virtualbox interferring with host audio when the VM boots.
Consolidate all nomad data dir in a single root
`/tmp/nomad-dev-cluster`.  Eases clean up.

Allow running script from any path - don't require devs to cd into
`dev/cluster` directory first.

Also, block while nomad processes are running and prapogate
SIGTERM/SIGINT to nomad processes to shutdown.
Emit a slightly helpful message when /api depends on nomad internal
packages.
@notnoop notnoop merged commit c7eb60b into master Feb 3, 2020
@notnoop notnoop deleted the r-dev-tweaks-20200203 branch February 3, 2020 19:25
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants