-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Node drain status light icons #7047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Michael! Two small things:
- Looks like the ACL token is missing, so all the eligibility and drain options are disabled. Not sure if that will be problematic, but I figured I would call it out.
- The icon for alerts looks a little distorted and not quite as wide as the Structure one.
Yeah, this is fine. Just a side effect of the mirage data when I took the screenshots.
I'm assuming you mean the triangular ones? Yes, it's an old icon I grabbed from elsewhere before Structure existed. I'll open an issue to address replacing that icon. |
Added #7050 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks for doing this! 🎉
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Augment the existing colored node status light/indicator with icons. This does a better job communicating state and it's also an accessibility no-no to communicate exclusively with color.
I also took this moment to emphasize Down clients on the list view: