Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Node drain status light icons #7047

Merged
merged 7 commits into from
Feb 1, 2020
Merged

Conversation

DingoEatingFuzz
Copy link
Contributor

Augment the existing colored node status light/indicator with icons. This does a better job communicating state and it's also an accessibility no-no to communicate exclusively with color.

image

image

image

image

I also took this moment to emphasize Down clients on the list view:

image

Copy link

@joshklekamp joshklekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Michael! Two small things:

  1. Looks like the ACL token is missing, so all the eligibility and drain options are disabled. Not sure if that will be problematic, but I figured I would call it out.
  2. The icon for alerts looks a little distorted and not quite as wide as the Structure one.

@DingoEatingFuzz
Copy link
Contributor Author

Looks like the ACL token is missing, so all the eligibility and drain options are disabled. Not sure if that will be problematic, but I figured I would call it out.

Yeah, this is fine. Just a side effect of the mirage data when I took the screenshots.

The icon for alerts looks a little distorted and not quite as wide as the Structure one.

I'm assuming you mean the triangular ones? Yes, it's an old icon I grabbed from elsewhere before Structure existed. I'll open an issue to address replacing that icon.

@DingoEatingFuzz
Copy link
Contributor Author

Added #7050

Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for doing this! 🎉

@DingoEatingFuzz DingoEatingFuzz merged commit ce3d581 into master Feb 1, 2020
@DingoEatingFuzz DingoEatingFuzz deleted the f-ui/node-drain-icons branch February 1, 2020 06:45
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants