Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CL and bump nomad version to v0.10.4 #7040

Merged
merged 2 commits into from
Feb 1, 2020
Merged

update CL and bump nomad version to v0.10.4 #7040

merged 2 commits into from
Feb 1, 2020

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Jan 31, 2020

No description provided.

@shoenig shoenig force-pushed the f-connect-acl-inc-version branch from c5ec50e to aa9636a Compare January 31, 2020 14:35
@shoenig shoenig requested a review from schmichael January 31, 2020 15:27
@shoenig
Copy link
Member Author

shoenig commented Jan 31, 2020

There's a couple of tests around ClusterID that depend on the Nomad version being 0.10.4 now, this helps those

schmichael
schmichael approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches; thanks!

@shoenig shoenig merged this pull request into dev-connect-acls Feb 1, 2020
@shoenig shoenig deleted the f-connect-acl-inc-version branch February 1, 2020 00:37
@shoenig shoenig mentioned this pull request Feb 1, 2020
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmichael schmichael schmichael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoenig @schmichael