Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI: Scheduler knows about CSI constraints and availability #6995

Merged
merged 18 commits into from
Jan 31, 2020
Merged

CSI: Scheduler knows about CSI constraints and availability #6995

merged 18 commits into from
Jan 31, 2020

Conversation

langmartin
Copy link
Contributor

@langmartin langmartin commented Jan 27, 2020 •
edited
Loading

Basic support for scheduling CSI jobs, closes #6908

@langmartin langmartin force-pushed the f-csi-volumes-feasibility branch from 1720226 to cad4e3a Compare January 28, 2020 16:29
tgross
tgross requested changes Jan 28, 2020
View reviewed changes
endocrimes
endocrimes suggested changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@langmartin langmartin force-pushed the f-csi-volumes-feasibility branch from 19ee749 to dcc2c71 Compare January 29, 2020 15:52
@langmartin langmartin changed the title Scheduler knows about CSI constraints and availability CSI: Scheduler knows about CSI constraints and availability Jan 29, 2020
@langmartin langmartin self-assigned this Jan 29, 2020
tgross
tgross approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

endocrimes
endocrimes suggested changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking like a really good start and covers one of the most common cases which is nice, but is missing a lot of the trickier understanding of CSI Scheduling right now (e.g handling Node only plugins)

endocrimes
endocrimes suggested changes Jan 30, 2020
View reviewed changes
@langmartin langmartin requested a review from endocrimes January 30, 2020 20:18
@langmartin langmartin merged commit fbb4539 into f-csi-volumes Jan 31, 2020
@langmartin langmartin deleted the f-csi-volumes-feasibility branch January 31, 2020 15:13
endocrimes added a commit that referenced this pull request Feb 7, 2020
@langmartin @endocrimes
CSI: Scheduler knows about CSI constraints and availability (#6995)
fc168e2 
* structs: piggyback csi volumes on host volumes for job specs

* state_store: CSIVolumeByID always includes plugins, matches usecase

* scheduler/feasible: csi volume checker

* scheduler/stack: add csi volumes

* contributing: update rpc checklist

* scheduler: add volumes to State interface

* scheduler/feasible: introduce new checker collection tgAvailable

* scheduler/stack: taskGroupCSIVolumes checker is transient

* state_store CSIVolumeDenormalizePlugins comment clarity

* structs: remote TODO comment in TaskGroup Validate

* scheduler/feasible: CSIVolumeChecker hasPlugins improve comment

* scheduler/feasible_test: set t.Parallel

* Update nomad/state/state_store.go

Co-Authored-By: Danielle <[email protected]>

* Update scheduler/feasible.go

Co-Authored-By: Danielle <[email protected]>

* structs: lift ControllerRequired to each volume

* state_store: store plug.ControllerRequired, use it for volume health

* feasible: csi match fast path remove stale host volume copied logic

* scheduler/feasible: improve comments

Co-authored-by: Danielle <[email protected]>
tgross pushed a commit that referenced this pull request Feb 13, 2020
@langmartin @endocrimes @tgross
CSI: Scheduler knows about CSI constraints and availability (#6995)
ce4bc04 
* structs: piggyback csi volumes on host volumes for job specs

* state_store: CSIVolumeByID always includes plugins, matches usecase

* scheduler/feasible: csi volume checker

* scheduler/stack: add csi volumes

* contributing: update rpc checklist

* scheduler: add volumes to State interface

* scheduler/feasible: introduce new checker collection tgAvailable

* scheduler/stack: taskGroupCSIVolumes checker is transient

* state_store CSIVolumeDenormalizePlugins comment clarity

* structs: remote TODO comment in TaskGroup Validate

* scheduler/feasible: CSIVolumeChecker hasPlugins improve comment

* scheduler/feasible_test: set t.Parallel

* Update nomad/state/state_store.go

Co-Authored-By: Danielle <[email protected]>

* Update scheduler/feasible.go

Co-Authored-By: Danielle <[email protected]>

* structs: lift ControllerRequired to each volume

* state_store: store plug.ControllerRequired, use it for volume health

* feasible: csi match fast path remove stale host volume copied logic

* scheduler/feasible: improve comments

Co-authored-by: Danielle <[email protected]>
@tgross tgross mentioned this pull request Feb 14, 2020
Closed
endocrimes added a commit that referenced this pull request Feb 17, 2020
@langmartin @endocrimes
CSI: Scheduler knows about CSI constraints and availability (#6995)
9d86c5e 
* structs: piggyback csi volumes on host volumes for job specs

* state_store: CSIVolumeByID always includes plugins, matches usecase

* scheduler/feasible: csi volume checker

* scheduler/stack: add csi volumes

* contributing: update rpc checklist

* scheduler: add volumes to State interface

* scheduler/feasible: introduce new checker collection tgAvailable

* scheduler/stack: taskGroupCSIVolumes checker is transient

* state_store CSIVolumeDenormalizePlugins comment clarity

* structs: remote TODO comment in TaskGroup Validate

* scheduler/feasible: CSIVolumeChecker hasPlugins improve comment

* scheduler/feasible_test: set t.Parallel

* Update nomad/state/state_store.go

Co-Authored-By: Danielle <[email protected]>

* Update scheduler/feasible.go

Co-Authored-By: Danielle <[email protected]>

* structs: lift ControllerRequired to each volume

* state_store: store plug.ControllerRequired, use it for volume health

* feasible: csi match fast path remove stale host volume copied logic

* scheduler/feasible: improve comments

Co-authored-by: Danielle <[email protected]>
tgross pushed a commit that referenced this pull request Mar 4, 2020
@langmartin @endocrimes @tgross
CSI: Scheduler knows about CSI constraints and availability (#6995)
5c029e9 
* structs: piggyback csi volumes on host volumes for job specs

* state_store: CSIVolumeByID always includes plugins, matches usecase

* scheduler/feasible: csi volume checker

* scheduler/stack: add csi volumes

* contributing: update rpc checklist

* scheduler: add volumes to State interface

* scheduler/feasible: introduce new checker collection tgAvailable

* scheduler/stack: taskGroupCSIVolumes checker is transient

* state_store CSIVolumeDenormalizePlugins comment clarity

* structs: remote TODO comment in TaskGroup Validate

* scheduler/feasible: CSIVolumeChecker hasPlugins improve comment

* scheduler/feasible_test: set t.Parallel

* Update nomad/state/state_store.go

Co-Authored-By: Danielle <[email protected]>

* Update scheduler/feasible.go

Co-Authored-By: Danielle <[email protected]>

* structs: lift ControllerRequired to each volume

* state_store: store plug.ControllerRequired, use it for volume health

* feasible: csi match fast path remove stale host volume copied logic

* scheduler/feasible: improve comments

Co-authored-by: Danielle <[email protected]>
tgross pushed a commit that referenced this pull request Mar 4, 2020
@langmartin @endocrimes @tgross
CSI: Scheduler knows about CSI constraints and availability (#6995)
b5696c3 
* structs: piggyback csi volumes on host volumes for job specs

* state_store: CSIVolumeByID always includes plugins, matches usecase

* scheduler/feasible: csi volume checker

* scheduler/stack: add csi volumes

* contributing: update rpc checklist

* scheduler: add volumes to State interface

* scheduler/feasible: introduce new checker collection tgAvailable

* scheduler/stack: taskGroupCSIVolumes checker is transient

* state_store CSIVolumeDenormalizePlugins comment clarity

* structs: remote TODO comment in TaskGroup Validate

* scheduler/feasible: CSIVolumeChecker hasPlugins improve comment

* scheduler/feasible_test: set t.Parallel

* Update nomad/state/state_store.go

Co-Authored-By: Danielle <[email protected]>

* Update scheduler/feasible.go

Co-Authored-By: Danielle <[email protected]>

* structs: lift ControllerRequired to each volume

* state_store: store plug.ControllerRequired, use it for volume health

* feasible: csi match fast path remove stale host volume copied logic

* scheduler/feasible: improve comments

Co-authored-by: Danielle <[email protected]>
tgross pushed a commit that referenced this pull request Mar 9, 2020
@langmartin @endocrimes @tgross
CSI: Scheduler knows about CSI constraints and availability (#6995)
029c5b5 
* structs: piggyback csi volumes on host volumes for job specs

* state_store: CSIVolumeByID always includes plugins, matches usecase

* scheduler/feasible: csi volume checker

* scheduler/stack: add csi volumes

* contributing: update rpc checklist

* scheduler: add volumes to State interface

* scheduler/feasible: introduce new checker collection tgAvailable

* scheduler/stack: taskGroupCSIVolumes checker is transient

* state_store CSIVolumeDenormalizePlugins comment clarity

* structs: remote TODO comment in TaskGroup Validate

* scheduler/feasible: CSIVolumeChecker hasPlugins improve comment

* scheduler/feasible_test: set t.Parallel

* Update nomad/state/state_store.go

Co-Authored-By: Danielle <[email protected]>

* Update scheduler/feasible.go

Co-Authored-By: Danielle <[email protected]>

* structs: lift ControllerRequired to each volume

* state_store: store plug.ControllerRequired, use it for volume health

* feasible: csi match fast path remove stale host volume copied logic

* scheduler/feasible: improve comments

Co-authored-by: Danielle <[email protected]>
langmartin added a commit that referenced this pull request Mar 13, 2020
@langmartin @endocrimes
CSI: Scheduler knows about CSI constraints and availability (#6995)
2df39b1 
* structs: piggyback csi volumes on host volumes for job specs

* state_store: CSIVolumeByID always includes plugins, matches usecase

* scheduler/feasible: csi volume checker

* scheduler/stack: add csi volumes

* contributing: update rpc checklist

* scheduler: add volumes to State interface

* scheduler/feasible: introduce new checker collection tgAvailable

* scheduler/stack: taskGroupCSIVolumes checker is transient

* state_store CSIVolumeDenormalizePlugins comment clarity

* structs: remote TODO comment in TaskGroup Validate

* scheduler/feasible: CSIVolumeChecker hasPlugins improve comment

* scheduler/feasible_test: set t.Parallel

* Update nomad/state/state_store.go

Co-Authored-By: Danielle <[email protected]>

* Update scheduler/feasible.go

Co-Authored-By: Danielle <[email protected]>

* structs: lift ControllerRequired to each volume

* state_store: store plug.ControllerRequired, use it for volume health

* feasible: csi match fast path remove stale host volume copied logic

* scheduler/feasible: improve comments

Co-authored-by: Danielle <[email protected]>
tgross pushed a commit that referenced this pull request Mar 16, 2020
@langmartin @endocrimes @tgross
CSI: Scheduler knows about CSI constraints and availability (#6995)
3ed56f8 
* structs: piggyback csi volumes on host volumes for job specs

* state_store: CSIVolumeByID always includes plugins, matches usecase

* scheduler/feasible: csi volume checker

* scheduler/stack: add csi volumes

* contributing: update rpc checklist

* scheduler: add volumes to State interface

* scheduler/feasible: introduce new checker collection tgAvailable

* scheduler/stack: taskGroupCSIVolumes checker is transient

* state_store CSIVolumeDenormalizePlugins comment clarity

* structs: remote TODO comment in TaskGroup Validate

* scheduler/feasible: CSIVolumeChecker hasPlugins improve comment

* scheduler/feasible_test: set t.Parallel

* Update nomad/state/state_store.go

Co-Authored-By: Danielle <[email protected]>

* Update scheduler/feasible.go

Co-Authored-By: Danielle <[email protected]>

* structs: lift ControllerRequired to each volume

* state_store: store plug.ControllerRequired, use it for volume health

* feasible: csi match fast path remove stale host volume copied logic

* scheduler/feasible: improve comments

Co-authored-by: Danielle <[email protected]>
tgross pushed a commit that referenced this pull request Mar 23, 2020
@langmartin @endocrimes @tgross
CSI: Scheduler knows about CSI constraints and availability (#6995)
3424c2e 
* structs: piggyback csi volumes on host volumes for job specs

* state_store: CSIVolumeByID always includes plugins, matches usecase

* scheduler/feasible: csi volume checker

* scheduler/stack: add csi volumes

* contributing: update rpc checklist

* scheduler: add volumes to State interface

* scheduler/feasible: introduce new checker collection tgAvailable

* scheduler/stack: taskGroupCSIVolumes checker is transient

* state_store CSIVolumeDenormalizePlugins comment clarity

* structs: remote TODO comment in TaskGroup Validate

* scheduler/feasible: CSIVolumeChecker hasPlugins improve comment

* scheduler/feasible_test: set t.Parallel

* Update nomad/state/state_store.go

Co-Authored-By: Danielle <[email protected]>

* Update scheduler/feasible.go

Co-Authored-By: Danielle <[email protected]>

* structs: lift ControllerRequired to each volume

* state_store: store plug.ControllerRequired, use it for volume health

* feasible: csi match fast path remove stale host volume copied logic

* scheduler/feasible: improve comments

Co-authored-by: Danielle <[email protected]>
tgross pushed a commit that referenced this pull request Mar 23, 2020
@langmartin @endocrimes @tgross
CSI: Scheduler knows about CSI constraints and availability (#6995)
f370e25 
* structs: piggyback csi volumes on host volumes for job specs

* state_store: CSIVolumeByID always includes plugins, matches usecase

* scheduler/feasible: csi volume checker

* scheduler/stack: add csi volumes

* contributing: update rpc checklist

* scheduler: add volumes to State interface

* scheduler/feasible: introduce new checker collection tgAvailable

* scheduler/stack: taskGroupCSIVolumes checker is transient

* state_store CSIVolumeDenormalizePlugins comment clarity

* structs: remote TODO comment in TaskGroup Validate

* scheduler/feasible: CSIVolumeChecker hasPlugins improve comment

* scheduler/feasible_test: set t.Parallel

* Update nomad/state/state_store.go

Co-Authored-By: Danielle <[email protected]>

* Update scheduler/feasible.go

Co-Authored-By: Danielle <[email protected]>

* structs: lift ControllerRequired to each volume

* state_store: store plug.ControllerRequired, use it for volume health

* feasible: csi match fast path remove stale host volume copied logic

* scheduler/feasible: improve comments

Co-authored-by: Danielle <[email protected]>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@endocrimes endocrimes endocrimes approved these changes

@tgross tgross tgross approved these changes

Assignees

@langmartin langmartin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@langmartin @endocrimes @tgross