Code

UI: add exec terminal#6697

Code

Merged

backspace merged 154 commits intomasterhashicorp/nomad:masterfrom f-ui/exechashicorp/nomad:f-ui/execCopy head branch name to clipboardMar 24, 2020

+1,633-74

Commits

Commits on Nov 13, 2019

• Add proxy that properly handles websockets

  Show description for 7256769
  backspace

  committed
  7256769

• Add xterm.js

  backspace

  committed
  11b0da4

• Add comment about proxy being preliminary

  backspace

  committed
  a6aed62

• Add prototype task-attached exec terminal

  Show description for caccb4b
  backspace

  committed
  caccb4b

• Fix lint errors

  backspace

  committed
  3f9fcb4

Commits on Nov 14, 2019

• Fix encoding to handle emoji 🥳

  backspace

  committed
  9bef4ad

Commits on Jan 27, 2020

• Merge branch 'master' into f-ui/exec

  Show description for dd4ecf9
  backspace

  committed
  dd4ecf9

• Add preliminary exec popup sidebar

  backspace

  committed
  1b92691

Commits on Jan 28, 2020

• Add show/hide of task group task list

  backspace

  committed
  55ef273

• Add preliminary styling

  Show description for dce93dd
  backspace

  committed
  dce93dd

• Change icon selector to have correct scope

  backspace

  committed
  a0a8f88

• Correct colour for exit icon

  backspace

  committed
  4bc5838

Commits on Jan 29, 2020

• Add preliminary header with job details

  backspace

  committed
  16160e1

• Change region/namespace to show conditionally

  backspace

  committed
  43370ea

• Add styling for popup navbar

  Show description for 922ebd9
  backspace

  committed
  922ebd9

• Remove new-window target for documentation for now

  backspace

  committed
  0eaf145

Commits on Jan 30, 2020

• Add terminal with task selection message

  Show description for 1710751
  backspace

  committed
  1710751

• Remove integration test for now

  backspace

  committed
  61c09b6

Commits on Feb 3, 2020

• Add auto-fit for terminal

  Show description for 75c2c57
  backspace

  committed
  75c2c57

• Add width for exec sidebar

  backspace

  committed
  6bd195e

• Add padding around terminal element

  backspace

  committed
  0256014

• Change task group to be closed by default

  backspace

  committed
  8747919

• Change task group to be opened by routing

  Show description for 3ff8f49
  backspace

  committed
  3ff8f49

Commits on Feb 4, 2020

• Change task items to links

  backspace

  committed
  94e50b2

• Add first step toward editable command output

  Show description for e6c469a
  backspace

  committed
  e6c469a

Commits on Feb 5, 2020

• Add handling for assigning/specifying allocations

  Show description for 20b7b14
  backspace

  committed
  20b7b14

• Add foreground text colouring

  Show description for 417f317
  backspace

  committed
  417f317

• Add note about wrapping task names in faux command

  backspace

  committed
  9cbf6dc

• Change typeface to match design

  backspace

  committed
  b255650

• Add note about sidebar allocation mismatches

  backspace

  committed
  4a69823

• Remove obsolete test setup

  backspace

  committed
  fbc4ce1

• Add preliminary incoming socket communication

  backspace

  committed
  fd3d379

• Add preliminary outgoing socket communication

  backspace

  committed
  56a7080

Commits on Feb 6, 2020

• Change sent message format for readability

  backspace

  committed
  f7397f1

• Change terminal font to monospace

  Show description for 14b1883
  backspace

  committed
  14b1883

• Add ability to customise exec command

  backspace

  committed
  f4dd4df

• Add guard against backspacing beyond command

  Show description for 2524fb6
  backspace

  committed
  2524fb6

• Add placeholder socket for Mirage context

  backspace

  committed
  a1960d2

Commits on Feb 7, 2020

• Add preliminary handling for socket closure

  backspace

  committed
  91a5d38

Commits on Feb 10, 2020

• Fix handling of emoji

  backspace

  committed
  183c86a

• Change allocation choice to ensure task is present

  backspace

  committed
  6d90cab

• Change sidebar links to maybe open in new window

  Show description for 80c4c29
  backspace

  committed
  80c4c29

Commits on Feb 11, 2020

• Add indicator for active task

  backspace

  committed
  f1cdf22

• Move exec-specific component to subdirectory

  Show description for 73668c5
  backspace

  committed
  73668c5

• Extract component for task items

  backspace

  committed
  568a860

• Add temporary logging of close events

  backspace

  committed
  80f598d

• Fix lint error

  backspace

  committed
  ad1f10b

• Add temporary fixed Faker seed

  backspace

  committed
  07330e5

Commits on Feb 12, 2020

• Extract ANSI colour-changing codes

  backspace

  committed
  71801d0

• Add escaping for faux CLI task names

  backspace

  committed
  5b0ff52

• Add link to origin of escaping regular expression

  backspace

  committed
  0ffe645

• Remove superfluous comments

  Show description for 1649705
  backspace

  committed
  1649705

Commits on Feb 13, 2020

• Fix sidebar for multi-line task names

  backspace

  committed
  844de68

• Fix sidebar for multi-line task group names

  backspace

  committed
  f117e1c

• Add FIXME about keeping opened groups open

  backspace

  committed
  967b352

• Add rejection of inactive task states

  backspace

  committed
  66551ea

• Add text colour change when switching tasks

  backspace

  committed
  5a86b9d

• Extract class for terminal command-editing

  Show description for 4c2713c
  backspace

  committed
  4c2713c

Commits on Feb 14, 2020

• Change const to let

  Show description for 0f6a6fa
  backspace

  committed
  0f6a6fa

• Add failing test for backspace wrapping

  Show description for 123eaab
  backspace

  committed
  123eaab

• Merge branch 'master' into f-ui/exec

  backspace

  committed
  2f900d2

Commits on Feb 18, 2020

• Add wraparound backspacing for command-editing

  Show description for c87c365
  backspace

  committed
  c87c365

• Change new window icon to not shrink

  backspace

  committed
  e0f2e60

• Extract adapter between Xterm.js and exec socket

  Show description for a47f06e
  backspace

  committed
  a47f06e

• Change sidebar to not shrink

  backspace

  committed
  21e3d5a

Commits on Feb 19, 2020

• Change new window icon to always take up space

  Show description for 8d65a27
  backspace

  committed
  8d65a27

Commits on Feb 20, 2020

• Add tooltip for new window icon

  backspace

  committed
  840f2ff

Commits on Feb 21, 2020

• Add TTY-sizing message when socket opens

  Show description for 7fdf5ea
  backspace

  committed
  7fdf5ea

• Add note about other formats for incoming messages

  backspace

  committed
  5de6f89

Commits on Mar 2, 2020

• Add handling for window resizing

  backspace

  committed
  7e5bcee

Commits on Mar 3, 2020

• Change more const to let

  backspace

  committed
  551d37a

• Change documentation link to open in new tab

  backspace

  committed
  4ef3388

• Change var to let

  backspace

  committed
  e138e71

• Fix bug with multiple socket-openings

  backspace

  committed
  83fef11

• Extract MockSocket class

  backspace

  committed
  50a082d

• Update vertical height of terminal

  Show description for 894c5ec
  backspace

  committed
  894c5ec

• Fix height of tree-and-terminal container

  Show description for 1429b52
  backspace

  committed
  1429b52

• Add assertion for terminal row count

  Show description for ae3a465
  backspace

  committed
  ae3a465

Commits on Mar 4, 2020

• Remove extraneous copypaste

  Show description for 646e52c
  backspace

  committed
  646e52c

• Add filter for what incoming frames are processed

  Show description for 240d0e0
  backspace

  committed
  240d0e0

• Update outdated comment

  backspace

  committed
  6c74c63

• Move public field into constructor

  Show description for 34a2db3
  backspace

  committed
  34a2db3

• Remove unused variables

  backspace

  committed
  b210afe

• Add required attribute

  Show description for 8c90b76
  backspace

  committed
  8c90b76

• Change assertion on initial terminal size

  Show description for 2524bda
  backspace

  committed
  2524bda

• Change TTY size assertion to reference terminal

  Show description for 3d32307
  backspace

  committed
  3d32307

• Merge remote-tracking branch 'origin/master' into f-ui/exec

  backspace

  committed
  877fc04

• Change resize integration test to dynamic values

  Show description for f87ba12
  backspace

  committed
  f87ba12

Commits on Mar 5, 2020

• Remove resize test dimension changes

  Show description for a7a528d
  backspace

  committed
  a7a528d

• Add renaming of task state to match task

  Show description for 97b4756
  backspace

  committed
  97b4756

• Add temporary logging of test application errors

  backspace

  committed
  479d9e7

• Merge remote-tracking branch 'origin/master' into f-ui/exec

  backspace

  committed
  2011286

• Remove pending clientStatus allocations for now

  Show description for 17a5db5
  backspace

  committed
  17a5db5

• Remove Faker override

  backspace

  committed
  4c57467

• Add flag to ensure no pending allocations

  Show description for 20a9f6d
  backspace

  committed
  20a9f6d

• Remove outdated comment

  backspace

  committed
  7afcda2

• Remove prototype implementation

  backspace

  committed
  f24ea68

• Remove note about Nomad logo in exec nav

  backspace

  committed
  0566d3e

• Add note about application in background

  backspace

  committed
  e40a904

• Add note about hardcoded host for sockets

  backspace

  committed
  1e1f92f

Commits on Mar 6, 2020

• Remove note about icon difference

  backspace

  committed
  90fd1a9

• Change sentence about customising command

  backspace

  committed
  846eca7

Commits on Mar 9, 2020

• Fix wrapping for task group names

  Show description for 90c003e
  backspace

  committed
  90c003e

Commits on Mar 10, 2020

• Fix width/wrapping of task name element

  backspace

  committed
  1e75d90

• Add note about arrow keys

  backspace

  committed
  7295eaa

• Fix overflow for sidebar

  backspace

  committed
  c13b55c

• Replace custom reverse-wraparound handling

  Show description for a0c177c
  backspace

  committed
  a0c177c

Commits on Mar 11, 2020

• Remove reverse-wraparound comment

  backspace

  committed
  7743dfd

• Add missing word

  backspace

  committed
  b7109f8

• Add preliminary button to open exec session

  Show description for 82611c9
  backspace

  committed
  82611c9

• Change exec URL-generation to use router service

  backspace

  committed
  31de6d6

• Add exec button to allocation title

  backspace

  committed
  e79c191

• Fix border colour of exec button

  backspace

  committed
  a448fcf

Commits on Mar 18, 2020

• Remove URL options from no-allocation URL

  Show description for 03d9a3b
  backspace

  committed
  03d9a3b

Commits on Mar 19, 2020

• Add skipped tests about inactive sidebar items

  backspace

  committed
  4d429d7

• Add exec button for task group header

  backspace

  committed
  1eb598b

• Add exec button for task detail header

  backspace

  committed
  d14ec81

• Remove unused variable

  backspace

  committed
  309f6c5

• Change socket URL-construction to be parameterised

  Show description for 795db54
  backspace

  committed
  795db54

Commits on Mar 20, 2020

• Convert to onData so paste works

  backspace

  committed
  d4f8672

• Add handling for non-data stdout messages

  backspace

  committed
  4d05dbe

• Remove task groups on non-running allocations

  backspace

  committed
  eda4bc0

Commits on Mar 23, 2020

• Add sidebar filtering to remove inactive tasks

  backspace

  committed
  9a890d9

• Remove verified FIXME comment

  backspace

  committed
  41273f5

Commits on Mar 24, 2020

• Extract exec URL generator

  Show description for fbc915b
  backspace

  committed
  fbc915b

• Add query parameters to generated exec URLs

  backspace

  committed
  a5a7629

• Add more whitespace for consistency

  backspace

  committed
  1c5f8fc

• Remove allocation exec button when not running

  backspace

  committed
  0010213

• Remove outdated FIXME

  backspace

  committed
  259b168

• Remove FIXMEs and accept pseudo two-step-button

  backspace

  committed
  3805d4e

• Fix appearance of short id tag on its own line

  backspace

  committed
  39d8c09

• Extract utility to open exec windows

  backspace

  committed
  4240004

• Remove outdated FIXME

  backspace

  committed
  c38397e

• Remove debugging error logging

  backspace

  committed
  53a4c81

• Replace FIXMEs with issue link

  backspace

  committed
  4fb8c2b

• Remove outdated FIXMEs

  backspace

  committed
  bc5615c

• Remove logging of socket close events

  backspace

  committed
  073aa25

• Remove outdated comment

  Show description for d60076f
  backspace

  committed
  d60076f

• Remove unused variable

  backspace

  committed
  41a8046

• Remove duplication of exec session command

  backspace

  committed
  e1d5918

• Add link to issue for remembering command changes

  backspace

  committed
  7c486fa

• Remove superfluous CSS comments

  backspace

  committed
  9e8b5da

• Remove extraneous whitespace

  backspace

  committed
  53f2972

• Replace TODO with issue link

  backspace

  committed
  f98619d

• Remove mock server comments

  backspace

  committed
  754df0a

• Add explanation of key event simulation

  backspace

  committed
  14b59af

• Change scrollbars to not be visible by default

  backspace

  committed
  c39c801

• Replace custom resize-handling with mixin

  backspace

  committed
  984195b

• Remove unneeded data-fetching

  Show description for 056f1f6
  backspace

  committed
  056f1f6

• Change component to be multi-line for readability

  backspace

  committed
  36ad190

• Remove unused import

  backspace

  committed
  a0335af

• Extract xterm backspacing string for clarity

  backspace

  committed
  4744ddf

• Replace console SVG with svgo-processed version

  Show description for 8a989c3
  backspace

  committed
  8a989c3

• Change name of SVG circle for active task

  backspace

  committed
  415c982